Added an experimental convert scripts option for godot3 export #11863

marcelofg55 · 2017-10-05T23:20:45Z

If enabled this option will convert gdscripts using regexp. So far it converts:

_fixed_process( => _physics_process(
_pos( => _position(
KEY_RETURN => KEY_ENTER
RawArray() => PoolByteArray()
Vector2Array() => PoolVector2Array()
.get_opacity() => .get_modulate().a
.set_opacity(var) => .modulate.a = var
.connect( => .connect_to_host( // (A HTTPClient object is detected first)
ReferenceFrame => Control
var.type == InputEvent.KEY => var.get_name() == "InputEventKey"
var.type == InputEvent.MOUSE_MOTION => var.get_name() == "InputEventMouseMotion"
var.type == InputEvent.MOUSE_BUTTON => var.get_name() == "InputEventMouseButton"
var.type == InputEvent.JOYSTICK_MOTION => var.get_name() == "InputEventJoypadMotion"
var.type == InputEvent.JOYSTICK_BUTTON => var.get_name() == "InputEventJoypadButton"
is_move_and_slide_on_floor() => is_on_floor()
is_move_and_slide_on_ceiling() => is_on_ceiling()
is_move_and_slide_on_wall() => is_on_wall()

Zylann · 2017-10-08T01:52:04Z

set_opacity() conversion must use current color, not white. (If you assume that any set_opacity function is called on an object having a modulate)

reduz · 2017-10-08T01:53:29Z

Wow On Oct 7, 2017 10:52 PM, "Marc" <[email protected]> wrote: set_opacity() conversion must use current color, not white. (If you assume that any set_opacity function is called on an object having a modulate) — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#11863 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AF-Z23wiw1R_uxXQpVG1-ZldalaNQfweks5sqCrOgaJpZM4Pv1A4> .

Zylann · 2017-10-08T01:54:29Z

You could also rename "len" identifiers into "length", because "len" is now a reserved function keyword (if there is no other variable in the same scope named "length" already)

Zylann · 2017-10-08T01:57:10Z

@reduz what's going on? :D

Zireael07 · 2017-10-08T08:32:16Z

Another candidate is FixedMaterial -> whatever the 3.0 equivalent is.

Zylann · 2017-10-08T11:23:23Z

Also AABB -> Rect3, Matrix -> Basis, ColorFrame -> ColorRect, Mesh -> ArrayMesh

Zylann · 2017-10-08T11:29:11Z

Maybe also .type == InputEvent.*** => is ***

HummusSamurai · 2017-10-09T05:11:44Z

When this is discussed for merge on IRC, I'd like to suggest that it be merged directly without waiting for all the changes to be added.

That way further additions to the conversion script can be contributed through subsequent PRs and help decentralise the effort.

akien-mga · 2017-10-09T10:35:25Z

For opacity, you can do changes in a non-destructive way (currently you're overriding potential modulate colors) with properties:

self.modulate.a = var

It would still overwrite the alpha channel of a potential modulate color, but we can assume that users were not using both opacity and modulate alpha at the same time.
Or we could do self.modulate.a *= var if we really want to be on the safe side :)

marcelofg55 · 2017-10-09T13:23:45Z

@Zylann

You could also rename "len" identifiers into "length", because "len" is now a reserved function keyword (if there is no other variable in the same scope named "length" already)

I thought about that one too, but it probably is a tricky one since you have to avoid getting false positives as len is a pretty short and common word. But I'll give it a try later.

Also AABB -> Rect3, Matrix -> Basis, ColorFrame -> ColorRect, Mesh -> ArrayMesh

Are these direct conversions? I haven't used them myself in gdscript, so idk.

Maybe also .type == InputEvent.*** => is ***

Added :).

marcelofg55 · 2017-10-09T13:24:15Z

@akien-mga Just fixed that modulate thing, thanks for the tip :).

reduz · 2017-10-09T15:55:57Z

this looks great, i think, if not implemented already, animations should also be properly fixed

27thLiz · 2017-10-09T16:45:39Z

editor/editor_export_godot3.cpp

+			}
+			regexp.clear();
+
+			// Convert var.type == InputEvent.KEY => var.get_name() == "InputEventKey"


This is not the recommended method for type checking.
Use var is InputEventKey instead.

Just fixed it.

akien-mga · 2018-03-15T14:11:01Z

editor/editor_export_godot3.cpp

+			regexp.clear();
+
+			// Convert .set_opacity(var) => .modulate.a = var
+			regexp.compile("([ \t]*)([a-zA-Z0-9_]*)[ ]*\\.set_opacity\\((.*)\\)(.*)");


@marcelofg55 I'm doing some improvements to the script conversion, and wonder about this regexp. What's the point of [ ]* before \\.set_opacity\\(? Shouldn't it simply be "(.*)\\.set_opacity\\((.*)\\)(.*)"?

I don't remember if there was a reason that I wrote that regexp that way, but it should work fine as you say as (.*)\\.set_opacity\\((.*)\\)(.*).

ghost added enhancement topic:editor labels Oct 6, 2017

ghost added this to the 2.1 milestone Oct 6, 2017

marcelofg55 force-pushed the conv_scripts_exp branch 2 times, most recently from aec1484 to 7e15835 Compare October 7, 2017 16:02

marcelofg55 force-pushed the conv_scripts_exp branch from 7e15835 to e1352ef Compare October 9, 2017 13:18

marcelofg55 force-pushed the conv_scripts_exp branch from e1352ef to 7db5398 Compare October 9, 2017 14:44

marcelofg55 changed the title ~~[WIP] Added an experimental convert scripts option for godot3 export~~ Added an experimental convert scripts option for godot3 export Oct 9, 2017

27thLiz suggested changes Oct 9, 2017

View reviewed changes

marcelofg55 force-pushed the conv_scripts_exp branch from 7db5398 to cecc893 Compare October 9, 2017 17:35

Added an experimental convert scripts option for godot3 export

cecc893

27thLiz approved these changes Oct 10, 2017

View reviewed changes

akien-mga merged commit b1ea083 into godotengine:2.1 Oct 11, 2017

marcelofg55 deleted the conv_scripts_exp branch October 12, 2017 02:01

akien-mga reviewed Mar 15, 2018

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added an experimental convert scripts option for godot3 export #11863

Added an experimental convert scripts option for godot3 export #11863

marcelofg55 commented Oct 5, 2017 •

edited

Loading

Zylann commented Oct 8, 2017

reduz commented Oct 8, 2017 via email

Zylann commented Oct 8, 2017

Zylann commented Oct 8, 2017

Zireael07 commented Oct 8, 2017

Zylann commented Oct 8, 2017

Zylann commented Oct 8, 2017

HummusSamurai commented Oct 9, 2017 •

edited

Loading

akien-mga commented Oct 9, 2017 •

edited

Loading

marcelofg55 commented Oct 9, 2017

marcelofg55 commented Oct 9, 2017

reduz commented Oct 9, 2017

27thLiz Oct 9, 2017

marcelofg55 Oct 9, 2017

akien-mga Mar 15, 2018

marcelofg55 Mar 15, 2018

Added an experimental convert scripts option for godot3 export #11863

Added an experimental convert scripts option for godot3 export #11863

Conversation

marcelofg55 commented Oct 5, 2017 • edited Loading

Zylann commented Oct 8, 2017

reduz commented Oct 8, 2017 via email

Zylann commented Oct 8, 2017

Zylann commented Oct 8, 2017

Zireael07 commented Oct 8, 2017

Zylann commented Oct 8, 2017

Zylann commented Oct 8, 2017

HummusSamurai commented Oct 9, 2017 • edited Loading

akien-mga commented Oct 9, 2017 • edited Loading

marcelofg55 commented Oct 9, 2017

marcelofg55 commented Oct 9, 2017

reduz commented Oct 9, 2017

27thLiz Oct 9, 2017

Choose a reason for hiding this comment

marcelofg55 Oct 9, 2017

Choose a reason for hiding this comment

akien-mga Mar 15, 2018

Choose a reason for hiding this comment

marcelofg55 Mar 15, 2018

Choose a reason for hiding this comment

marcelofg55 commented Oct 5, 2017 •

edited

Loading

HummusSamurai commented Oct 9, 2017 •

edited

Loading

akien-mga commented Oct 9, 2017 •

edited

Loading